MaxGekk commented on a change in pull request #26134: [SPARK-29486][SQL]
CalendarInterval should have 3 fields: months, days and microseconds
URL: https://github.com/apache/spark/pull/26134#discussion_r336642318
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala
##########
@@ -103,9 +103,9 @@ object TimeWindow {
*/
private def getIntervalInMicroSeconds(interval: String): Long = {
val cal = CalendarInterval.fromCaseInsensitiveString(interval)
- if (cal.months > 0) {
+ if (cal.months > 0 || cal.days > 0) {
Review comment:
Intervals with days could be converted to microseconds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
