cloud-fan commented on a change in pull request #26164: [SPARK-21492][SQL] Fix
memory leak in SortMergeJoin
URL: https://github.com/apache/spark/pull/26164#discussion_r336849806
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
##########
@@ -1040,3 +1044,57 @@ class JoinSuite extends QueryTest with
SharedSparkSession {
checkAnswer(df, Row(1, 2, 1, 2) :: Nil)
}
}
+
+class JoinWithResourceCleanSuite extends JoinSuite with BeforeAndAfterAll {
+ import testImplicits._
+ import scala.collection.mutable.ArrayBuffer
+
+ private def checkCleanupResourceTriggered(plan: SparkPlan):
ArrayBuffer[SortExec] = {
Review comment:
It took me a while to understand the tests.
So this method doesn't trigger the check, but attach the checker which will
be run later.
How about we redefine this method as `def attachChecker(checkCodegen:
Boolean): Unit`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
