cloud-fan commented on a change in pull request #26164: [SPARK-21492][SQL] Fix 
memory leak in SortMergeJoin
URL: https://github.com/apache/spark/pull/26164#discussion_r336874416
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
 ##########
 @@ -37,6 +39,27 @@ import org.apache.spark.sql.types.StructType
 class JoinSuite extends QueryTest with SharedSparkSession {
   import testImplicits._
 
+  private def checkCleanupResourceTriggered(plan: SparkPlan): 
ArrayBuffer[SortExec] = {
 
 Review comment:
   how about `attachCleanupResourceChecker`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to