MaxGekk commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-544534832 > @MaxGekk I don't think performance is a strong reason to move parsing logic from antlr to hand-written jave code. It's better to centralize the parsing stuff in antlr. I would agree with you till Spark support bulk loading of interval strings. Also I think it doesn't matter for users how do you implement parsing. If two implementation are functionally equivalent, users would prefer the fastest one, I think.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
