MaxGekk commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545315235 The benchmark numbers are significantly bigger on my laptop - 6-7 times slower: ```diff diff --git a/sql/core/benchmarks/IntervalBenchmark-results.txt b/sql/core/benchmarks/IntervalBenchmark-results.txt index 9010b980c0..bf6dc17b59 100644 --- a/sql/core/benchmarks/IntervalBenchmark-results.txt +++ b/sql/core/benchmarks/IntervalBenchmark-results.txt @@ -2,24 +2,24 @@ Java HotSpot(TM) 64-Bit Server VM 1.8.0_202-b08 on Mac OS X 10.15 Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz cast strings to intervals: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ -string w/ interval 420 435 18 2.4 419.8 1.0X -string w/o interval 359 365 10 2.8 358.7 1.2X -1 units w/ interval 752 759 8 1.3 752.0 0.6X -1 units w/o interval 762 766 4 1.3 762.0 0.6X -2 units w/ interval 961 970 8 1.0 960.7 0.4X -2 units w/o interval 970 976 9 1.0 970.2 0.4X -3 units w/ interval 1130 1136 7 0.9 1130.4 0.4X -3 units w/o interval 1150 1158 9 0.9 1150.3 0.4X -4 units w/ interval 1333 1336 3 0.7 1333.5 0.3X -4 units w/o interval 1354 1359 4 0.7 1354.5 0.3X -5 units w/ interval 1523 1525 2 0.7 1523.3 0.3X -5 units w/o interval 1549 1551 3 0.6 1549.4 0.3X -6 units w/ interval 1661 1663 2 0.6 1660.8 0.3X -6 units w/o interval 1691 1704 13 0.6 1691.2 0.2X -7 units w/ interval 1811 1817 8 0.6 1810.6 0.2X -7 units w/o interval 1853 1854 1 0.5 1853.2 0.2X -8 units w/ interval 2029 2037 8 0.5 2028.7 0.2X -8 units w/o interval 2075 2075 1 0.5 2074.5 0.2X -9 units w/ interval 2170 2175 5 0.5 2170.0 0.2X -9 units w/o interval 2204 2212 8 0.5 2203.6 0.2X +string w/ interval 443 504 55 2.3 442.6 1.0X +string w/o interval 395 412 19 2.5 394.7 1.1X +1 units w/ interval 5741 5744 3 0.2 5740.7 0.1X +1 units w/o interval 5524 5615 84 0.2 5524.4 0.1X +2 units w/ interval 6981 7055 75 0.1 6980.6 0.1X +2 units w/o interval 6333 6353 22 0.2 6333.3 0.1X +3 units w/ interval 7663 7713 66 0.1 7663.2 0.1X +3 units w/o interval 7428 7452 40 0.1 7427.6 0.1X +4 units w/ interval 8698 8732 36 0.1 8698.2 0.1X +4 units w/o interval 8514 8530 14 0.1 8514.3 0.1X +5 units w/ interval 9874 9892 26 0.1 9874.3 0.0X +5 units w/o interval 9552 9597 67 0.1 9551.6 0.0X +6 units w/ interval 10920 10957 39 0.1 10919.6 0.0X +6 units w/o interval 10796 11081 253 0.1 10795.8 0.0X +7 units w/ interval 12086 12110 25 0.1 12086.2 0.0X +7 units w/o interval 11901 11928 25 0.1 11900.9 0.0X +8 units w/ interval 13387 13422 33 0.1 13387.1 0.0X +8 units w/o interval 13184 13193 10 0.1 13183.7 0.0X +9 units w/ interval 14688 14701 17 0.1 14688.5 0.0X +9 units w/o interval 14484 14513 29 0.1 14483.6 0.0X ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
