dongjoon-hyun commented on a change in pull request #26190: [SPARK-29532][SQL]
simplify interval string parsing
URL: https://github.com/apache/spark/pull/26190#discussion_r337252065
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -79,6 +79,10 @@ singleTableSchema
: colTypeList EOF
;
+singleInterval
+ : INTERVAL? (intervalValue intervalUnit)+ EOF
Review comment:
Thank you for pinging me, @cloud-fan . It must be a corner case which we
overlooked before. +1 for banning the case `SELECT INTERVAL 'INTERVAL 1 year'`
in Apache Spark 3.0. What we need is only `SELECT INTERVAL '1 year'`. In other
words,
- `SELECT INTERVAL 'INTERVAL 1 year'` (X)
- `SELECT INTERVAL '1 year'` (O)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
