HeartSaVioR commented on issue #26173: [SPARK-29503][SQL] Copy result row from 
RowWriter in GenerateUnsafeProjection when the expression is lambdaFunction in 
MapObject
URL: https://github.com/apache/spark/pull/26173#issuecomment-544743408
 
 
   Would it work if we replace `CreateNamedStructUnsafe` to `CreateNamedStruct` 
in lambda expression of MapObjects?
   
   I'm not sure we don't miss anything as it only deals with struct type, but 
what we discovered for now is struct type, so the approach makes sense to me 
for resolving SPARK-29503. Just a view of as non-expert of SQL, current 
approach makes me feel safer though, in the sense of defensive programming.
   
   I would wait to hear more voices before making change so we don't do back 
and forth. Thanks for the suggestion!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to