HeartSaVioR commented on issue #26173: [SPARK-29503][SQL] Copy result row from RowWriter in GenerateUnsafeProjection when the expression is lambdaFunction in MapObject URL: https://github.com/apache/spark/pull/26173#issuecomment-545137654 I quickly checked the usage of `CreateNamedStructUnsafe`, and it is only used in `UnsafeProjection.toUnsafeExprs`. If UnsafeProjection converts the result of evaluations of expressions into UnsafeRow (it should), I don't see strict need to care about individual expression, at least logically. So I'm seeing the same, CreateNamedStructUnsafe doesn't seem to be needed at all. As a side effect `UnsafeProjection.toUnsafeExprs` is also not needed at all as well. I've just removed them and rebased the branch to contain only the change. The new test passes with new change, so let's see the build result. Old commit hash to revert: 6187d99
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
