HeartSaVioR commented on issue #26201: [SPARK-29543][SS][UI] Init structured 
streaming ui
URL: https://github.com/apache/spark/pull/26201#issuecomment-544870405
 
 
   >> It may be better to define a new event for SQL and pass through listener 
bus, so that it could be available to SHS as well. It seems to be the right 
approach even we just want to expose it in running application.
   
   > This is a great suggestion. I agree with you. But IMHO, we can do it in a 
separate PR after/before this.
   
   Actually my point was, it seems to be a bit weird to make SQL event listener 
to be couple with other stuff. It's an event listener, and the best way to 
ingest the data into that listener is sending event. I'm not saying we should 
enable this in SHS right now, but it will be available smoothly if we follow 
the general way to ingest the data.
   
   >> Is there any chance to reuse resources for streaming tab? It's basically 
close to streaming tab, but looks like it doesn't reuse anything.
   
   > Basically, streaming query is also a sql query, so it is reasonable to 
place the entry in SQL Tab. But it does not mean I object to use a streaming 
tab. Besides, I am not sure it is a good choice to reuse existing streaming tab.
   
   I meant the graph between streaming tab and here would be quite similar, so 
curious it could be reused, maybe with refactoring if necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to