HeartSaVioR commented on issue #26201: [SPARK-29543][SS][UI] Init structured 
streaming ui
URL: https://github.com/apache/spark/pull/26201#issuecomment-544945548
 
 
   >> I meant the graph between streaming tab and here would be quite similar, 
so curious it could be reused, maybe with refactoring if necessary.
   
   > Get it. If so, we should do some refactoring work, since these two code 
path are located in two different packages. I do not mind to do this work in a 
follow-up PR. What is your opinion?
   
   I'm OK with it. Let's reconsider if someone claims again.
   
   >> Actually my point was, it seems to be a bit weird to make SQL event 
listener to be couple with other stuff.
   
   > Sorry, I do not get what you mean. Could you please point out the codebase 
where you are referring
   
   Sorry my bad. I was confused SQLTab with SQL listener. I'd still suggest 
looping through SQL listener and access through SQLAppStore, but that's OK as 
it is once we are OK with supporting it only for Spark UI (not SHS).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to