AngersZhuuuu commented on issue #25721: [WIP][SPARK-29018][SQL] Implement Spark Thrift Server with it's own code base on PROTOCOL_VERSION_V9 URL: https://github.com/apache/spark/pull/25721#issuecomment-545705591 > * Keep CLIService.java, ThriftCLIService.java, ThriftHttpServlet.java, ... - all things that don't really get modified by Spark in Java > * Do Spark specific implementation in scala, and remove the no longer needed Java thriftserver impl. E.g. (Spark)ExecuteStatementOperation.scala and remove ExecuteStatementOperation.java; (Spark)OperationManager.scala and remove OperationManager.java etc. etc. > OR > Translate all these Java files to scala, like is done in this PR? It's ok to do like this, since base class like `ThriftCLIService` `ThriftHttpServlet` dose not rely hive. We can remain it as java code. then we implement `Operations` `HiveSession` `SessionManager` etc..
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
