AngersZhuuuu commented on issue #25721: [WIP][SPARK-29018][SQL] Implement Spark Thrift Server with it's own code base on PROTOCOL_VERSION_V9 URL: https://github.com/apache/spark/pull/25721#issuecomment-545708779 > I am confused. It seems that in this PR you already did translation from Java to Scala of all Hive Thriftserver code? I assume it was mostly somehow autogenerated? > A lot of these classes don't really change much from Hive to Spark, except for mechanical translation from Java to Scala, renaming package names, removing dependence on some Hive objects. Do I see correctly? > I would commit these in a separate PR, to separate "mechanical" changes from places that were actually rewritten. Not just translated, but first work is direct translated. However, in some code, there will be some parts of hive version conflict, I need to solve these. I need to make sure it can work in different hiev version 1.2.1/2.3.5 . Some basic hive class is stable, that is the best news. But finally, we want to implement a thriftserver that is completely independent of hive
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
