fuwhu commented on a change in pull request #26230: [SPARK-21287][SQL] Move the
validation of fetch size from JDBCOptions to JdbcDialect
URL: https://github.com/apache/spark/pull/26230#discussion_r338449670
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -150,6 +151,20 @@ abstract class JdbcDialect extends Serializable {
def beforeFetch(connection: Connection, properties: Map[String, String]):
Unit = {
}
+ /**
+ * Do some extra properties validation work in addition to the validation
+ * in [[org.apache.spark.sql.execution.datasources.jdbc.JDBCOptions]].
+ * @param properties The connection properties. This is passed through from
the relation.
+ */
+ def validateProperties(properties: Map[String, String]): Unit = {
Review comment:
I chose scala Map because i saw the JdbcDialect.beforeFetch accepts scala
Map as parameter.
I agree with you, we may consider changing the parameter type for both
beforeFetch and validateProperties, but i think we can leave this to another
PR.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
