fuwhu commented on a change in pull request #26230: [SPARK-21287][SQL] Move the
validation of fetch size from JDBCOptions to JdbcDialect
URL: https://github.com/apache/spark/pull/26230#discussion_r338607428
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
##########
@@ -147,14 +147,7 @@ class JDBCOptions(
""".stripMargin
)
- val fetchSize = {
- val size = parameters.getOrElse(JDBC_BATCH_FETCH_SIZE, "0").toInt
- require(size >= 0,
Review comment:
@srowen @HyukjinKwon I think both of these two solutions should be ok, so I
submitted another PR #26244 which just remove the check of non-negative
condition in JDBCOptions.
You can decide which one to follow up, i'll close the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
