vanzin commented on a change in pull request #26108: [SPARK-26154][SS]
Streaming left/right outer join should not return outer nulls for already
matched rows
URL: https://github.com/apache/spark/pull/26108#discussion_r338832143
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -476,6 +586,8 @@ class SymmetricHashJoinStateManager(
}
object SymmetricHashJoinStateManager {
+ val supportedVersions = Seq(1, 2)
Review comment:
It would be good to just reference the same values as the config entry.
In fact, since the config is internal, you could probably just drop the
check there, and rely on the checks in this code to make sure the version if
correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
