vanzin commented on a change in pull request #26108: [SPARK-26154][SS]
Streaming left/right outer join should not return outer nulls for already
matched rows
URL: https://github.com/apache/spark/pull/26108#discussion_r339773380
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -497,4 +608,20 @@ object SymmetricHashJoinStateManager {
private def getStateStoreName(joinSide: JoinSide, storeType:
StateStoreType): String = {
s"$joinSide-$storeType"
}
+
+ /**
+ * Helper class for representing data key to (value, matched).
+ * Designed for object reuse.
+ */
+ case class KeyToValueAndMatched(
Review comment:
I commented on the other class name, but the comment also applies to this
one. `AndMatched` is very specific, I'd prefer to keep a more generic name
(e.g. `KeyToValuePair` to kinda follow the old `UnsafeRowPair` name).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
