HeartSaVioR commented on a change in pull request #26108: [SPARK-26154][SS]
Streaming left/right outer join should not return outer nulls for already
matched rows
URL: https://github.com/apache/spark/pull/26108#discussion_r338993910
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1069,6 +1069,16 @@ object SQLConf {
.checkValue(v => Set(1, 2).contains(v), "Valid versions are 1 and 2")
.createWithDefault(2)
+ val STREAMING_JOIN_STATE_FORMAT_VERSION =
+ buildConf("spark.sql.streaming.join.stateFormatVersion")
+ .internal()
+ .doc("State format version used by streaming join operations in a
streaming query. " +
+ "State between versions are tend to be incompatible, so state format
version shouldn't " +
+ "be modified after running.")
+ .intConf
+ .checkValue(v => Set(1, 2).contains(v), "Valid versions are 1 and 2")
Review comment:
Nice suggestion. Btw, the line is actually consistent with the old things,
`STREAMING_AGGREGATION_STATE_FORMAT_VERSION`,
`FLATMAPGROUPSWITHSTATE_STATE_FORMAT_VERSION`. Would we like to change them as
well? Maybe from follow-up PR then to exclude unrelated changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
