HeartSaVioR commented on a change in pull request #26108: [SPARK-26154][SS]
Streaming left/right outer join should not return outer nulls for already
matched rows
URL: https://github.com/apache/spark/pull/26108#discussion_r338997182
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -139,13 +141,20 @@ case class StreamingSymmetricHashJoinExec(
rightKeys: Seq[Expression],
joinType: JoinType,
condition: Option[Expression],
+ stateFormatVersion: Int,
left: SparkPlan,
right: SparkPlan) = {
this(
leftKeys, rightKeys, joinType, JoinConditionSplitPredicates(condition,
left, right),
stateInfo = None, eventTimeWatermark = None,
- stateWatermarkPredicates = JoinStateWatermarkPredicates(), left, right)
+ stateWatermarkPredicates = JoinStateWatermarkPredicates(),
stateFormatVersion, left, right)
+ }
+
+ if (stateFormatVersion < 2 && joinType != Inner) {
+ logError(s"The query is using stream-stream outer join with state format
version" +
Review comment:
Actually this correctness issue is somewhat occurred in "corner case", so I
wasn't 100% sure we want to force end users to discard their checkpoint. #24890
is a similar case for "possible" correctness issue and we just log warn message.
If we would like to avoid possible correctness issue in any case, I'm OK to
let the query fail. Forcing end users to drop checkpoint might be unhappy one,
though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
