srowen commented on a change in pull request #26261: [SPARK-29607][SQL] Move
static methods from CalendarInterval to IntervalUtils
URL: https://github.com/apache/spark/pull/26261#discussion_r339308838
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -119,4 +121,202 @@ object IntervalUtils {
case _: IllegalArgumentException => null
}
}
+
+ private val yearMonthPattern = Pattern.compile("^([+|-])?(\\d+)-(\\d+)$")
+
+ private val dayTimePattern = Pattern.compile(
+ "^([+|-])?((\\d+) )?((\\d+):)?(\\d+):(\\d+)(\\.(\\d+))?$")
+
+ private def toLongWithRange(
+ fieldName: String,
+ s: String,
+ minValue: Long,
+ maxValue: Long): Long = {
+ var result = 0L
+ if (s != null) {
+ result = java.lang.Long.parseLong(s)
+ if (result < minValue || result > maxValue) {
+ throw new IllegalArgumentException(
+ s"$fieldName $result outside range [$minValue, $maxValue]")
+ }
+ }
+ result
+ }
+
+ /**
+ * Parse YearMonth string in form: [-]YYYY-MM
+ *
+ * adapted from HiveIntervalYearMonth.valueOf
+ */
+ def fromYearMonthString(input: String): CalendarInterval = {
+ if (input == null) throw new IllegalArgumentException("Interval year-month
string was null")
+ val s = input.trim
+ val m = yearMonthPattern.matcher(s)
+ if (!m.matches) {
+ throw new IllegalArgumentException(
+ "Interval string does not match year-month format of 'y-m': " + s)
Review comment:
Also we can use string interpolation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
