srowen commented on a change in pull request #26261: [SPARK-29607][SQL] Move
static methods from CalendarInterval to IntervalUtils
URL: https://github.com/apache/spark/pull/26261#discussion_r339570913
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -119,4 +121,202 @@ object IntervalUtils {
case _: IllegalArgumentException => null
}
}
+
+ private val yearMonthPattern = Pattern.compile("^([+|-])?(\\d+)-(\\d+)$")
Review comment:
Why does it need any restructuring? `"...".r` gives you an object with
pretty much the same API. You don't have to use regex pattern matching in Scala
if it's disruptive. Well, I don't feel strongly about it, just doesn't seem any
more of a change than you've already made in adapting this code to Scala.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
