Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4343#discussion_r24040441
  
    --- Diff: core/src/test/scala/org/apache/spark/util/AkkaUtilsSuite.scala ---
    @@ -371,7 +371,7 @@ class AkkaUtilsSuite extends FunSuite with 
LocalSparkContext with ResetSystemPro
           AkkaUtils.address(AkkaUtils.protocol(slaveSystem), "spark", 
"localhost", boundPort, "MapOutputTracker"))
         val timeout = AkkaUtils.lookupTimeout(conf)
         intercept[TimeoutException] {
    -      slaveTracker.trackerActor = 
Await.result(selection.resolveOne(timeout), timeout)
    +      slaveTracker.trackerActor = 
Await.result(selection.resolveOne(timeout * 2), timeout)
    --- End diff --
    
    Could you explain the the PR's comment (= the commit message) how 
increasing a timeout fixes a race condition, instead of just making it less 
likely?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to