Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/4343#issuecomment-72858032
@pwendell I think the problem with catching either exception is that the
`ActorNotFoundException` is also thrown in other situations - in this
particular test we want to prove that actor system A cannot connect to the
other actor system B because A doesn't trust B, and this results in timeout.
This is even lower communication layer than SASL.
On the other hand `ActorNotFoundException` is thrown in case of timeout, in
case there is no actor with that name or in case of authentication problems -
completely different situations because they occur when we are successfully
connected to the other actor system and that remote actor system refuses to
return the reference to the requested actor.
Therefore, `ActorNotFoundException` when not related to the timeout should
cause the test to fail because it means that we successfully connected to
untrusted actor system.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
