LucaCanali commented on a change in pull request #26170: [SPARK-29397][core] Extend plugin interface to include the driver. URL: https://github.com/apache/spark/pull/26170#discussion_r339577127
########## File path: docs/monitoring.md ########## @@ -1060,10 +1060,10 @@ when running in local mode. - hiveClientCalls.count - sourceCodeSize (histogram) -- namespace=<Executor Plugin Class Name> - - Optional namespace(s). Metrics in this namespace are defined by user-supplied code, and - configured using the Spark executor plugin infrastructure. - See also the configuration parameter `spark.executor.plugins` +- namespace=<Plugin Class Name> Review comment: I think it could make sense to add a similar entry about plugin metrics to the driver componenet instance metrics list, similarly to what has been done for the namespace=JVMCPU, for example. Please add \< to escape the "<" character (this issue actually comes from SPARK-20891) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
