Github user koeninger commented on the pull request:

    https://github.com/apache/spark/pull/3798#issuecomment-72760900
  
    To put it another way, the type you return has to be public.
    
    If you return a public abstract class, what are you going to do when
    someone else subclasses it?
    
    Making it a final concrete class doesn't have that issue.
    On Feb 3, 2015 5:34 PM, "Tathagata Das" <[email protected]> wrote:
    
    > But of course there can be multiple implementations! For example, there is
    > both KafkaReceiver and ReliableKafkaReceiver. The second was introduced so
    > that the code path for existing uses is not disturbed when we are
    > introducing experimental code paths that are optionally enabled with 
flags.
    > We never envisioned that happening, but when it occur, we could do this
    > because the KafkaReceiver was not exposed, only the Receiver interface was
    > exposed.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/spark/pull/3798#issuecomment-72759859>.
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to