Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3798#issuecomment-72775013
Yes, Cody, I agree that this has changed a number of time. But this is not
unusual for adding such a significant, publicly visible API such as this.
USually this level of API arguments occurs over design docs over a period of
time. However, since we were short on time in this matter and not all
implementation complexities were evident from the beginning, this had to be
done over the code. I can thank you enough for your cooperation!!!
So the two main changes are
1. sc.createNewStream (maybe rename DeterministicKafkaStream to Direct.... )
2. createRDD returns RDD
There are smaller suggestions and issues regarding documentation,
indentation, etc. However, I am willing to address them in another PR. Let's
merge this after you have made these two changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
