cloud-fan commented on a change in pull request #26134: [SPARK-29486][SQL]
CalendarInterval should have 3 fields: months, days and microseconds
URL: https://github.com/apache/spark/pull/26134#discussion_r341084431
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -63,10 +63,10 @@ case class ExtractIntervalMonths(child: Expression)
extends ExtractIntervalPart(child, ByteType, getMonths, "getMonths")
case class ExtractIntervalDays(child: Expression)
- extends ExtractIntervalPart(child, LongType, getDays, "getDays")
+ extends ExtractIntervalPart(child, IntegerType, getDays, "getDays")
case class ExtractIntervalHours(child: Expression)
- extends ExtractIntervalPart(child, ByteType, getHours, "getHours")
+ extends ExtractIntervalPart(child, LongType, getHours, "getHours")
Review comment:
Why the hours need to be long type now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
