cloud-fan commented on a change in pull request #26134: [SPARK-29486][SQL]
CalendarInterval should have 3 fields: months, days and microseconds
URL: https://github.com/apache/spark/pull/26134#discussion_r341198541
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2702,7 +2715,10 @@ object Sequence {
| $arr[$i] = ($elemType) ($t / ${scale}L);
| $i += 1;
| $t =
org.apache.spark.sql.catalyst.util.DateTimeUtils.timestampAddInterval(
- | $startMicros, $i * $stepMonths, $i * $stepMicros, $zid);
+ | $startMicros,
+ | new org.apache.spark.unsafe.types.CalendarInterval(
Review comment:
Sorry I missed this place. It has performance penalty if we create an object
every time. Let's go back to the previous version. Sorry for the back and
forth!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
