vanzin commented on a change in pull request #26108: [SPARK-26154][SS]
Streaming left/right outer join should not return outer nulls for already
matched rows
URL: https://github.com/apache/spark/pull/26108#discussion_r341371963
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -148,18 +177,19 @@ class SymmetricHashJoinStateManager(
/**
* Remove using a predicate on values.
*
- * At a high level, this produces an iterator over the (key, value) pairs
such that value
- * satisfies the predicate, where producing an element removes the value
from the state store
- * and producing all elements with a given key updates it accordingly.
+ * At a high level, this produces an iterator over the (key, value, matched)
tuples such that
+ * value satisfies the predicate, where producing an element removes the
value from the
+ * state store and producing all elements with a given key updates it
accordingly.
*
* This implies the iterator must be consumed fully without any other
operations on this manager
* or the underlying store being interleaved.
*/
- def removeByValueCondition(removalCondition: UnsafeRow => Boolean):
Iterator[UnsafeRowPair] = {
- new NextIterator[UnsafeRowPair] {
+ def removeByValueCondition(removalCondition: UnsafeRow => Boolean)
+ : Iterator[KeyToValuePair] = {
Review comment:
Fits in previous line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
