vanzin commented on a change in pull request #26108: [SPARK-26154][SS]
Streaming left/right outer join should not return outer nulls for already
matched rows
URL: https://github.com/apache/spark/pull/26108#discussion_r341371708
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
##########
@@ -294,9 +313,15 @@ case class StreamingSymmetricHashJoinExec(
}
}
val removedRowIter = rightSideJoiner.removeOldState()
- val outerOutputIter = removedRowIter
- .filterNot(pair => matchesWithLeftSideState(pair))
- .map(pair => joinedRow.withLeft(nullLeft).withRight(pair.value))
+ val outerOutputIter = removedRowIter.filterNot { kv =>
+ stateFormatVersion match {
+ case 1 => matchesWithLeftSideState(
Review comment:
I find that if your statement doesn't fit in the same line as the `case`,
it's easier to read when it starts on the next line. Otherwise the indentation
of the next lines look weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
