juliuszsompolski commented on issue #26340: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver with all code and UT URL: https://github.com/apache/spark/pull/26340#issuecomment-548802560 > But there is one thing. We can't use beeline in hadoop-2.7 if we keep changed code in hive-2.3.5 I think that once we change the package name we use in our code, beeline will pull the code from a hive-service dependency instead of this code and then it should work? ... but then, you would have to already in this first change move this namespace, and it would already be a big change, changing every file, I see... So maybe indeed keep this new `sql/thriftserver` module, but in the first PR try to get it working completely, but with the least changes first? Move code from `sql/hive-thriftserver`, move the package names, and try to make minimal changes to make it work: no java->scala translation, not removing of intermediate classes, not modifying the rowsets etc... And in the description marking each file that needed to be modified beyond changing the package name, so that it can be reviewed? When it's in a working state this way, it could be merged, and then further PRs could be kept to a few hundred lines and be managable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
