juliuszsompolski commented on issue #26340: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver with all code and UT URL: https://github.com/apache/spark/pull/26340#issuecomment-549420244 Thanks @AngersZhuuuu . I will have time to come back to look into it more in a few days. In the meanwhile, could you get the PR to compile and run tests? I think that for that you have to commit the thrift generated sources after all. We could keep the maven build step as an optional manual step that can be executed when somebody wants to regenerate it, and add instructions for it to `sql/thriftserver/README.md`. Can the maven plugin enforce the thrift compiler version? We could add instructions to README to use 0.9.3, and get and install it from https://www.apache.org/dist/thrift/0.9.3/. Otherwise, I found that even small thrift version differences lead to tiny annoying differences in all the generated files that make a huge diff when I regenerate it. I will look at @yaooqinn Kyuubi more as well. I wasn't aware of it's existence before! I think it could be great if improvements from there could be intergrated into mainline Spark. But I don't know how compatible it is with current thriftserver deployments? Kyuubi seems to not have a HTTP server right now, and also seems to be dependent on hive-1.2.1?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
