MaxGekk commented on a change in pull request #26132: [SPARK-29387][SQL]
Support `*` and `/` operators for intervals
URL: https://github.com/apache/spark/pull/26132#discussion_r341959212
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
##########
@@ -59,6 +59,27 @@ public CalendarInterval subtract(CalendarInterval that) {
return new CalendarInterval(months, days, microseconds);
}
+ private static CalendarInterval fromDoubles(
+ double monthsWithFraction,
+ double daysWithFraction,
+ double microsWithFraction) {
+ int truncatedMonths = Math.toIntExact((long)(monthsWithFraction));
+ // Using 30 days per month as PostgreSQL does.
+ double days = daysWithFraction + 30 * (monthsWithFraction -
truncatedMonths);
+ int truncatedDays = Math.toIntExact((long)days);
+ double micros = microsWithFraction + MICROS_PER_DAY * (days -
truncatedDays);
+ long truncatedMicros = Math.round(micros);
+ return new CalendarInterval(truncatedMonths, truncatedDays,
truncatedMicros);
+ }
+
+ public CalendarInterval multiply(double num) {
Review comment:
- In that case, our implementation will deviate from postgesql which uses
double internally. At the moment, we return the same results as postgresql (or
I haven't found yet the case when the results are different).
- most likely, it will be slower
If it is ok, I will switch to decimals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
