rezasafi commented on issue #26365: [SPARK-29720][CORE] Add linux condition to 
make ProcfsMetricsGetter more complete
URL: https://github.com/apache/spark/pull/26365#issuecomment-549476736
 
 
   Actually I am not sure whether we will report the correct metrics in other 
procfsbased systems since our computation is based on 
http://man7.org/linux/man-pages/man5/proc.5.html which is linux dependent. I 
haven't tested this feature on non-linux based systems. So I think it make 
sense to check whether the OS is actually linux. Thanks for the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to