rezasafi commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete URL: https://github.com/apache/spark/pull/26365#issuecomment-549610512 @ulysses-you In my last comment I said this PR make sense. Although I juts checked the Solaris. There is no stat file there so the prosfcs metrics will raise an exception and return all zero because of the check in this [line](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala#L201). It won't give back wrong info to the user in case of solaris. The same may be correct for other OSes. Still no harm in having your change if others also agree.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
