Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4067#discussion_r24133742
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -669,6 +673,7 @@ private[spark] object JsonProtocol {
metrics.incLocalBlocksFetched((json \ "Local Blocks
Fetched").extract[Int])
metrics.incFetchWaitTime((json \ "Fetch Wait Time").extract[Long])
metrics.incRemoteBytesRead((json \ "Remote Bytes Read").extract[Long])
+ metrics.incRecordsRead((json \ "Records
Read").extractOpt[Long].getOrElse(-1))
--- End diff --
Should this just be "0" instead of "-1". We have -1in a few places but it's
for metrics which are not aggregated like this. The weird thing here is that
we'll actually keep aggregating more and more negatives.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
