Github user ksakellis commented on a diff in the pull request:
https://github.com/apache/spark/pull/4067#discussion_r24206958
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala ---
@@ -193,12 +194,11 @@ private[spark] class DiskBlockObjectWriter(
}
objOut.writeObject(value)
+ numRecordsWritten += 1
--- End diff --
If the BlockObjectWriter can be reopened, wouldn't we we need to reset some
other variables too? Like finalPosition, initialPosition and reportedPosition?
They are set during construction? I don't see anywhere any enforcement of
reopening the BlockObjectWriter. We could either reset all the variables i
mentioned on open() or we can add a check that once the blockObjectWriter has
been opened, it can't be reopened. I'm leaning towards the latter. what do you
think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
