AngersZhuuuu commented on a change in pull request #26340: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver with all code and UT URL: https://github.com/apache/spark/pull/26340#discussion_r343027573
########## File path: sql/thriftserver/README.md ########## @@ -0,0 +1,3 @@ +Thrift commands to generate files from TCLIService.thrift: +-------------------- +thrift --gen java:beans,hashcode -o src/gen/thrift if/TCLIService.thrift Review comment: > Could you add `generated_annotations=undated` to avoid diffs? > And add a sentence like `Please use Thrift 0.9.3 available from https://www.apache.org/dist/thrift/0.9.3/.` Sorry for didn't notice this point. I'll update this later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
