xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL]
Support MERGE INTO in the parser and add the corresponding logical plan
URL: https://github.com/apache/spark/pull/26167#discussion_r343459789
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -106,6 +106,31 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
val columns = u.columns.map(UnresolvedAttribute(_))
UpdateTable(aliased, columns, u.values, u.condition)
+ case m @ MergeIntoTable(target, source, _, _, _) =>
Review comment:
Yea, I revisited the code and remove this unnecessary logic.
BTW, I kept some of checking v1 table logic for `MergeIntoTable` in
`ResolveSessionCatalog`, but it seems not a good choice to place the v1 table
check there for just checking. What do you think? Should we move the check to
`CheckAnalysis` or somewhere else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
