xianyinxin commented on a change in pull request #26167: [SPARK-28893][SQL]
Support MERGE INTO in the parser and add the corresponding logical plan
URL: https://github.com/apache/spark/pull/26167#discussion_r343492336
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -296,6 +296,44 @@ case class UpdateTable(
override def children: Seq[LogicalPlan] = table :: Nil
}
+/**
+ * The logical plan of the MERGE INTO command that works for v2 tables.
+ */
+case class MergeIntoTable(
+ targetTable: LogicalPlan,
+ sourceTable: LogicalPlan,
+ mergeCondition: Expression,
+ matchedActions: Seq[MergeAction],
+ notMatchedActions: Seq[MergeAction]) extends Command with SupportsSubquery
{
+ override def children: Seq[LogicalPlan] =
+ Seq(targetTable, sourceTable) ++ Nil
+ override def output: Seq[Attribute] = Seq.empty
+ override lazy val resolved: Boolean = expressions.forall(_.resolved) &&
childrenResolved &&
+ matchedActions.forall(_.resolved) && notMatchedActions.forall(_.resolved)
+}
+
+sealed abstract class MergeAction(
Review comment:
I found we can't left it be resolved automatically because there're some
cases we have to deal with manually like expand stars. It's not easy to extract
an expand-star logic in `MergeIntoTable`, so in the latest code I left the
reference resolve logic for `MergeIntoTable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
