gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE]
Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper
URL: https://github.com/apache/spark/pull/26397#discussion_r343722265
##########
File path:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
##########
@@ -1283,6 +1285,57 @@ class FsHistoryProviderSuite extends SparkFunSuite with
Matchers with Logging {
assert(deserializedOldObj.isComplete === false)
}
+ test("SPARK-29755 LogInfo should be serialized/deserialized by jackson
properly") {
+ def assertSerDe(serializer: KVStoreScalaSerializer, info: LogInfo): Unit =
{
+ val infoAfterSerDe = serializer.deserialize(
+ serializer.serialize(info), classOf[LogInfo])
Review comment:
Nit: No break needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
