gaborgsomogyi commented on a change in pull request #26397: [SPARK-29755][CORE]
Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper
URL: https://github.com/apache/spark/pull/26397#discussion_r343725514
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -1170,14 +1172,14 @@ private[history] case class LogInfo(
appId: Option[String],
attemptId: Option[String],
fileSize: Long,
- lastIndex: Option[Long],
+ @JsonDeserialize(contentAs = classOf[JLong]) lastIndex: Option[Long],
isComplete: Boolean)
private[history] class AttemptInfoWrapper(
val info: ApplicationAttemptInfo,
val logPath: String,
val fileSize: Long,
- val lastIndex: Option[Long],
+ @JsonDeserialize(contentAs = classOf[JLong]) val lastIndex: Option[Long],
Review comment:
Nit: Maybe a break break between deser and the val would make it more
readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
