tgravescs commented on a change in pull request #26440:
[WIP][SPARK-20628][CORE] Start to improve Spark decommissioning & preemption
support
URL: https://github.com/apache/spark/pull/26440#discussion_r344381616
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -137,6 +141,8 @@ private[spark] class CoarseGrainedExecutorBackend(
case LaunchTask(data) =>
if (executor == null) {
exitExecutor(1, "Received LaunchTask command but executor was null")
+ } else if (decommissioned) {
+ logWarning("Asked to launch a task while decommissioned. Not
launching.")
Review comment:
don't we want to tell drive that we didn't launch it? this.statusUpdate?
I'd have to look a bit close on what happens if we just never launch it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
