Github user ksakellis commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4067#discussion_r24223601
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala 
---
    @@ -358,5 +374,12 @@ class ShuffleWriteMetrics extends Serializable {
       private[spark] def incShuffleWriteTime(value: Long) = _shuffleWriteTime 
+= value
       private[spark] def decShuffleWriteTime(value: Long) = _shuffleWriteTime 
-= value
       
    -
    +  /**
    +   * Total number of records written to the shuffle by this task
    +   */
    +  @volatile private var _recordsWritten: Long = _
    --- End diff --
    
    oh, must have missed this. Yes we can rename it. I thought it was redundant 
because the class is already called ShuffleWriteMetrics.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to