Github user ksakellis commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4067#discussion_r24223586
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala ---
    @@ -193,12 +194,11 @@ private[spark] class DiskBlockObjectWriter(
         }
     
         objOut.writeObject(value)
    +    numRecordsWritten += 1
    --- End diff --
    
    Yes, i guess that is the least we can do. Having an explicit check i think 
would be better. So if we are okay with it, i can add a boolean that tracks if 
the blockwriter has been opened before and if so, don't allow it to be 
reopened. Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to