juliuszsompolski commented on a change in pull request #26215:
[SPARK-29559][Webui] Support pagination for JDBC/ODBC Server page
URL: https://github.com/apache/spark/pull/26215#discussion_r346228411
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
##########
@@ -69,45 +72,56 @@ private[ui] class ThriftServerPage(parent:
ThriftServerTab) extends WebUIPage(""
/** Generate stats of batch statements of the thrift server program */
private def generateSQLStatsTable(request: HttpServletRequest): Seq[Node] = {
+
val numStatement = listener.getExecutionList.size
+
val table = if (numStatement > 0) {
- val headerRow = Seq("User", "JobID", "GroupID", "Start Time", "Finish
Time", "Close Time",
- "Execution Time", "Duration", "Statement", "State", "Detail")
- val tooltips = Seq(None, None, None, None,
Some(THRIFT_SERVER_FINISH_TIME),
- Some(THRIFT_SERVER_CLOSE_TIME), Some(THRIFT_SERVER_EXECUTION),
- Some(THRIFT_SERVER_DURATION), None, None, None)
- assert(headerRow.length == tooltips.length)
- val dataRows = listener.getExecutionList.sortBy(_.startTimestamp).reverse
-
- def generateDataRow(info: ExecutionInfo): Seq[Node] = {
- val jobLink = info.jobId.map { id: String =>
- <a href={"%s/jobs/job/?id=%s".format(
- UIUtils.prependBaseUri(request, parent.basePath), id)}>
- [{id}]
- </a>
+
+ val sqlTableTag = "sqlstat"
+
+ val parameterOtherTable = request.getParameterMap().asScala
+ .filterNot(_._1.startsWith(sqlTableTag))
+ .map { case (name, vals) =>
+ name + "=" + vals(0)
}
- val detail =
Option(info.detail).filter(!_.isEmpty).getOrElse(info.executePlan)
- <tr>
- <td>{info.userName}</td>
- <td>
- {jobLink}
- </td>
- <td>{info.groupId}</td>
- <td>{formatDate(info.startTimestamp)}</td>
- <td>{if (info.finishTimestamp > 0)
formatDate(info.finishTimestamp)}</td>
- <td>{if (info.closeTimestamp > 0)
formatDate(info.closeTimestamp)}</td>
- <td
sorttable_customkey={info.totalTime(info.finishTimestamp).toString}>
Review comment:
@shahidki31 @srowen Is the new table not sortable now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
