juliuszsompolski commented on a change in pull request #26215:
[SPARK-29559][Webui] Support pagination for JDBC/ODBC Server page
URL: https://github.com/apache/spark/pull/26215#discussion_r346264756
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
##########
@@ -202,3 +191,254 @@ private[ui] class ThriftServerPage(parent:
ThriftServerTab) extends WebUIPage(""
}
}
+private[ui] class SqlStatsPagedTable(
+ request: HttpServletRequest,
+ parent: ThriftServerTab,
+ data: Seq[ExecutionInfo],
+ subPath: String,
+ basePath: String,
+ parameterOtherTable: Iterable[String],
+ sqlStatsTableTag: String,
+ pageSize: Int,
+ sortColumn: String,
+ desc: Boolean) extends PagedTable[SqlStatsTableRow] {
+
+ override val dataSource = new SqlStatsTableDataSource(data, pageSize,
sortColumn, desc)
+
+ private val parameterPath =
s"$basePath/$subPath/?${parameterOtherTable.mkString("&")}"
+
+ override def tableId: String = sqlStatsTableTag
+
+ override def tableCssClass: String =
+ "table table-bordered table-condensed table-striped " +
+ "table-head-clickable table-cell-width-limited"
+
+ override def pageLink(page: Int): String = {
+ val encodedSortColumn = URLEncoder.encode(sortColumn, UTF_8.name())
+ parameterPath +
+ s"&$pageNumberFormField=$page" +
+ s"&$sqlStatsTableTag.sort=$encodedSortColumn" +
+ s"&$sqlStatsTableTag.desc=$desc" +
+ s"&$pageSizeFormField=$pageSize"
+ }
+
+ override def pageSizeFormField: String = s"$sqlStatsTableTag.pageSize"
+
+ override def pageNumberFormField: String = s"$sqlStatsTableTag.page"
+
+ override def goButtonFormPath: String = {
+ val encodedSortColumn = URLEncoder.encode(sortColumn, UTF_8.name())
+
s"$parameterPath&$sqlStatsTableTag.sort=$encodedSortColumn&$sqlStatsTableTag.desc=$desc"
+ }
+
+ override def headers: Seq[Node] = {
+ val sqlTableHeaders = Seq("User", "JobID", "GroupID", "Start Time",
"Finish Time",
+ "Close Time", "Execution Time", "Duration", "Statement", "State",
"Detail")
+
+ val tooltips = Seq(None, None, None, None, Some(THRIFT_SERVER_FINISH_TIME),
+ Some(THRIFT_SERVER_CLOSE_TIME), Some(THRIFT_SERVER_EXECUTION),
+ Some(THRIFT_SERVER_DURATION), None, None, None)
+
+ assert(sqlTableHeaders.length == tooltips.length)
+
+ val headerRow: Seq[Node] = {
+ sqlTableHeaders.zip(tooltips).map { case (header, tooltip) =>
+ if (header == sortColumn) {
+ val headerLink = Unparsed(
+ parameterPath +
+ s"&$sqlStatsTableTag.sort=${URLEncoder.encode(header,
UTF_8.name())}" +
+ s"&$sqlStatsTableTag.desc=${!desc}" +
+ s"&$sqlStatsTableTag.pageSize=$pageSize" +
+ s"#$sqlStatsTableTag")
+ val arrow = if (desc) "▾" else "▴" // UP or DOWN
+
+ if (tooltip.nonEmpty) {
+ <th>
+ <a href={headerLink}>
+ <span data-toggle="tooltip" title={tooltip.get}>
+ {header} {Unparsed(arrow)}
+ </span>
+ </a>
+ </th>
+ } else {
+ <th>
+ <a href={headerLink}>
+ {header} {Unparsed(arrow)}
+ </a>
+ </th>
+ }
+ } else {
+ val headerLink = Unparsed(
+ parameterPath +
+ s"&$sqlStatsTableTag.sort=${URLEncoder.encode(header,
UTF_8.name())}" +
+ s"&$sqlStatsTableTag.pageSize=$pageSize" +
+ s"#$sqlStatsTableTag")
+
+ if(tooltip.nonEmpty) {
+ <th>
+ <a href={headerLink}>
+ <span data-toggle="tooltip" title={tooltip.get}>
+ {header}
+ </span>
+ </a>
+ </th>
+ } else {
+ <th>
+ <a href={headerLink}>
+ {header}
+ </a>
+ </th>
+ }
+ }
+ }
+ }
+ <thead>
+ {headerRow}
+ </thead>
+ }
+
+ override def row(sqlStatsTableRow: SqlStatsTableRow): Seq[Node] = {
+ val info = sqlStatsTableRow.executionInfo
+ val startTime = info.startTimestamp
+ val executionTime = sqlStatsTableRow.executionTime
+ val duration = sqlStatsTableRow.duration
+
+ def jobLinks(jobData: Seq[String]): Seq[Node] = {
+ jobData.map { jobId =>
+ <a href={jobURL(request, jobId)}>[{jobId.toString}]</a>
+ }
+ }
+
+ <tr>
+ <td>
+ {info.userName}
+ </td>
+ <td>
+ {jobLinks(sqlStatsTableRow.jobId)}
+ </td>
+ <td>
+ {info.groupId}
+ </td>
+ <td >
+ {UIUtils.formatDate(startTime)}
+ </td>
+ <td>
+ {if (info.finishTimestamp > 0) formatDate(info.finishTimestamp)}
+ </td>
+ <td>
+ {if (info.closeTimestamp > 0) formatDate(info.closeTimestamp)}
Review comment:
Thanks for the explanation. Sorry for my confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
