shahidki31 commented on a change in pull request #26508: [SPARK-26260][Core]For
disk store tasks summary table should show only successful tasks summary
URL: https://github.com/apache/spark/pull/26508#discussion_r346427745
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
##########
@@ -136,12 +136,6 @@ private[spark] class AppStatusStore(
store.read(classOf[StageDataWrapper], Array(stageId,
stageAttemptId)).locality
}
- // SPARK-26119: we only want to consider successful tasks when calculating
the metrics summary,
Review comment:
I think "very expensive" meant for disk store case. Because of the
deserialising overhead, the InMemory code path for disk store is expensive.
Vanzin has commented in the previous PR
https://github.com/apache/spark/pull/23088#discussion_r237197020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
