shahidki31 commented on a change in pull request #26508: [SPARK-26260][Core]For 
disk store tasks summary table should show only successful tasks summary
URL: https://github.com/apache/spark/pull/26508#discussion_r346434043
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
 ##########
 @@ -136,12 +136,6 @@ private[spark] class AppStatusStore(
     store.read(classOf[StageDataWrapper], Array(stageId, 
stageAttemptId)).locality
   }
 
-  // SPARK-26119: we only want to consider successful tasks when calculating 
the metrics summary,
 
 Review comment:
   And these loading time can be further reduced. Because currently stage UI 
requires only 9 tasks metrics summary, I think. But we are calculating 
summaries of 16 tasks metrics. Instead if we compute only 9 for UI, again the 
loading time can be reduced. I'll raise a new PR for that optimisation too. cc 
@vanzin

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to