xingyif commented on a change in pull request #26430: [SPARK-28859][Core]
Requires MEMORY_OFFHEAP_SIZE value must be > 0 when user specifies
URL: https://github.com/apache/spark/pull/26430#discussion_r346479582
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -254,7 +254,7 @@ package object config {
"consumption must fit within some hard limit then be sure to shrink your
JVM heap size " +
"accordingly. This must be set to a positive value when
spark.memory.offHeap.enabled=true.")
.bytesConf(ByteUnit.BYTE)
- .checkValue(_ >= 0, "The off-heap memory size must not be negative")
+ .checkValue(_ > 0, "The off-heap memory size must be positive.")
Review comment:
Thomas Graves and I had a discussion about this in the
[jira](https://issues.apache.org/jira/browse/SPARK-28859) ticket. When user
specifies the value, it requires the specified value to be > 0. However, if the
user doesn't change the value (default), the it is ok to have it to be 0.
> Default of 0 is fine that is why I said if the user specifies a value it
should be > 0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
