xingyif commented on a change in pull request #26430: [SPARK-28859][Core]
Requires MEMORY_OFFHEAP_SIZE value must be > 0 when user specifies
URL: https://github.com/apache/spark/pull/26430#discussion_r346491454
##########
File path:
core/src/test/scala/org/apache/spark/memory/UnifiedMemoryManagerSuite.scala
##########
@@ -309,6 +309,15 @@ class UnifiedMemoryManagerSuite extends
MemoryManagerSuite with PrivateMethodTes
mm.invokePrivate[Unit](assertInvariants())
}
+ test("invalid MEMORY_OFFHEAP_SIZE") {
+ val conf = new SparkConf()
+ .set(MEMORY_OFFHEAP_SIZE, 0)
Review comment:
Thanks, Dongjoon. Removed the test case since you mentioned that there is
already another `.checkValue` itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
